This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH,nvptx] Truncate config/nvptx/oacc-parallel.c
- From: Tom de Vries <tdevries at suse dot de>
- To: Cesar Philippidis <cesar at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 1 Aug 2018 13:33:09 +0200
- Subject: Re: [PATCH,nvptx] Truncate config/nvptx/oacc-parallel.c
- References: <email@example.com>
On 07/31/2018 05:55 PM, Cesar Philippidis wrote:
> Way back in the GCC 5 days when support for OpenACC was in its infancy,
> we used to rely on having various GOACC_ thread functions in the runtime
> to implement the execution model, or there lack of (that version of GCC
> only supported vector level parallelism). However, beginning with GCC 6,
> those external functions were replaced with internal functions that get
> expanded by the nvptx BE directly.
> This patch removes those stale libgomp functions from the nvptx libgomp
> target. Is this OK for trunk, or does libgomp still need to maintain
> backwards compatibility with GCC 5?
> This patch has been bootstrapped and regtested for x86_64 with nvptx
AFAIU, if you use a GCC 5 nvptx offloading compiler that generates calls
to these GOACC_ thread functions, you're also expected to use the GCC 5
nvptx libgomp.a containing these functions, so I don't see any backwards
compatibility issues here.
OK for me.
Jakub, do you have an opinion here?