This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] PR libstdc++/70940 optimize pmr::resource_adaptor for allocators using malloc
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 26 Jul 2018 12:19:02 +0100
- Subject: Re: [PATCH] PR libstdc++/70940 optimize pmr::resource_adaptor for allocators using malloc
- References: <20180723194020.GA13044@redhat.com> <yddsh468d4z.fsf@CeBiTec.Uni-Bielefeld.DE>
On 26/07/18 13:11 +0200, Rainer Orth wrote:
Rainer, this is another place where alignof(max_align_t) gets encoded
into the ABI, so is affected by PR 77691 as well.
indeed, fixed by the following patch. Tested on i386-pc-solaris2.11,
ok for mainline?
The ugly thing about xfailing the affected tests is that they will XPASS
once in a while when malloc happens to return 16-byte aligned memory.
However, I'm reluctant to skip them instead at least while there's a
chance that Solaris will fix 32-bit x86 malloc alignment post Solaris
Yes, it isn't ideal to have them flip between XFAIL and XPASS, but I
agree that simply skipping them is worse.