This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

From: Qing Zhao <qing dot zhao at oracle dot com>
To: gcc Patches <gcc-patches at gcc dot gnu dot org>
Cc: jakub Jelinek <jakub at redhat dot com>, jeff Law <law at redhat dot com>, richard Biener <rguenther at suse dot de>, Wilco Dijkstra <wilco dot dijkstra at arm dot com>
Date: Wed, 25 Jul 2018 12:08:40 -0500
Subject: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os

Hi,

As Wilco suggested, the new added strcmp/strncmp inlining should be only enabled with O2 and above.

this is the simple patch for this change.

tested on both X86 and aarch64.

Okay for thunk?

Qing

gcc/ChangeLog:

+2018-07-25  Qing Zhao  <qing.zhao@oracle.com>
+
+       * builtins.c (inline_expand_builtin_string_cmp): Disable inlining
+       when optimization level is lower than 2 or optimize for size.
+       

gcc/testsuite/ChangeLog:

+2018-07-25  Qing Zhao  <qing.zhao@oracle.com>
+
+       * gcc.dg/strcmpopt_5.c: Change to O2 to enable the transformation.
+       * gcc.dg/strcmpopt_6.c: Likewise.
+

Attachment: 78809_O2.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os
  - From: Richard Biener
- Re: [PATCH][Middle-end] disable strcmp/strncmp inlining with O2 below and Os
  - From: Christophe Lyon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]