This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Sort Altivec/VSX built-in functions into subsubsections according to configuration requirements


On Tue, Jul 17, 2018 at 03:44:43PM -0500, Kelvin Nilsen wrote:
> The many PowerPC built-in functions (intrinsics) that are enabled by including <altivec.h> each have different configuration requirements.  To simplify the description of the requirements, this patch sorts these functions into different subsubsections.  
> 
> A subsequent patch will add and remove various functions from each section to correct incompatibilities between what is implemented and what is documented.
> 
> I have built and regression tested this patch on powerpc64le-unknown-linux and on powerpc-linux (P8 big-endian) with no regressions.  I have also built and reviewed the gcc.pdf file.

A changelog nit:

> 	* doc/extend.texi (PowerPC AltiVec/VSX Built-in Functions):
> 	Corrected spelling of this subsection.  Moved some material to new
> 	subsubsections "PowerPC AltiVec Built-in Functions on ISA 2.06" and
> 	"PowerPC AltiVec Built-in Functions on ISA 2.07".

	* doc/extend.texi (PowerPC AltiVec Built-in Functions): Rename to...
	(PowerPC AltiVec/VSX Built-in Functions): ... this.  Move some material
	to new subsubsections "PowerPC AltiVec Built-in Functions on ISA 2.06"
	and "PowerPC AltiVec Built-in Functions on ISA 2.07".

(I.e., mention old name as well as new, and use imperative instead of
past tense).

Looks fine otherwise.  Okay for trunk.  Thanks!


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]