This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Update config.guess and config.sub
- From: Jeff Law <law at redhat dot com>
- To: Palmer Dabbelt <palmer at sifive dot com>, sebastian dot huber at embedded-brains dot de, ilg at livius dot net
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 5 Jul 2018 11:03:59 -0600
- Subject: Re: [PATCH] Update config.guess and config.sub
- References: <mhng-e6e91574-62ad-4123-9fa0-fb0809141b52@palmer-si-x1c4>
On 07/05/2018 10:51 AM, Palmer Dabbelt wrote:
> On Thu, 05 Jul 2018 05:00:20 PDT (-0700),
> sebastian.huber@embedded-brains.de wrote:
>> * config.guess: Sync with upstream version 2018-06-26.
>> * config.sub: Sync with upstream version 2018-07-02.
>> ---
>> config.guess | 6 +++---
>> config.sub | 8 +++++++-
>> 2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/config.guess b/config.guess
>> index 883a6713bf0..445c406836e 100755
>> --- a/config.guess
>> +++ b/config.guess
>> @@ -2,7 +2,7 @@
>> # Attempt to guess a canonical system name.
>> # Copyright 1992-2018 Free Software Foundation, Inc.
>>
>> -timestamp='2018-05-19'
>> +timestamp='2018-06-26'
>>
>> # This file is free software; you can redistribute it and/or modify it
>> # under the terms of the GNU General Public License as published by
>> @@ -894,8 +894,8 @@ EOF
>> # other systems with GNU libc and userland
>> echo "$UNAME_MACHINE-unknown-`echo "$UNAME_SYSTEM" | sed
>> 's,^[^/]*/,,' | tr "[:upper:]" "[:lower:]"``echo "$UNAME_RELEASE"|sed
>> -e 's/[-(].*//'`-$LIBC"
>> exit ;;
>> - i*86:Minix:*:*)
>> - echo "$UNAME_MACHINE"-pc-minix
>> + *:Minix:*:*)
>> + echo "$UNAME_MACHINE"-unknown-minix
>> exit ;;
>> aarch64:Linux:*:*)
>> echo "$UNAME_MACHINE"-unknown-linux-"$LIBC"
>> diff --git a/config.sub b/config.sub
>> index d1f5b549034..072700fb037 100755
>> --- a/config.sub
>> +++ b/config.sub
>> @@ -2,7 +2,7 @@
>> # Configuration validation subroutine script.
>> # Copyright 1992-2018 Free Software Foundation, Inc.
>>
>> -timestamp='2018-05-24'
>> +timestamp='2018-07-02'
>>
>> # This file is free software; you can redistribute it and/or modify it
>> # under the terms of the GNU General Public License as published by
>> @@ -1125,6 +1125,12 @@ case $basic_machine in
>> ps2)
>> basic_machine=i386-ibm
>> ;;
>> + riscv)
>> + basic_machine=riscv32-unknown
>> + ;;
>> + riscv-*)
>> + basic_machine=`echo "$basic_machine" | sed 's/^riscv/riscv32/'`
>> + ;;
>> rm[46]00)
>> basic_machine=mips-siemens
>> ;;
>
> I'm not sure what the policy is on getting config stuff approved for
> commit, but just FYI there's another RISC-V related patch to config.sub
> that changes the behavior of "riscv-*" tuples. I'm assuming we should
> take both, as it's odd to sync half way to the head of config.
>
> When I try to build it I see "Unsupported RISC-V target
> riscv-unknown-elf", so there's at least some extra autoconf wizadry that
> needs to happen in here. I'm actually not sure what the "riscv-*"
> tuples are supposed to do so I've added Liviu as I don't want to
> misrepresent his desires and get into trouble again :).
>
> I'm fine with pretty much anything when it comes to this tuple stuff, so
> feel free to consider it all pre-approved from a RISC-V prospective --
> though I assume it needs a GCC global maintainer to approve it as well.
> My only constraint is that it doesn't break anything that currently
> builds, as I don't want to force a flag day on everyone because of this.
>
> Thanks for submitting the patch!
>
> Here's the config commit, for reference:
>
> commit dd5d5dd697df579a5ebd119a88475b446c07c6b0
> Author: Ben Elliston <bje@gnu.org>
> Date: Tue Jul 3 21:18:29 2018 +1000
>
> * config.sub: Do not rewrite riscv -> riscv32.
> * testsuite/config-sub.data: Adjust tests.
If this is from upstream, consider it pre-approved for the trunk.
jeff