This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] More location fixes to grokdeclarator

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: David Malcolm <dmalcolm at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 3 Jul 2018 20:37:10 +0200
Subject: Re: [C++ Patch] More location fixes to grokdeclarator
References: <67f2fc3d-020c-96b7-3176-2c8a8687c758@oracle.com> <1530057173.23999.152.camel@redhat.com> <66ac831c-83df-7fe5-22e4-656891bd8773@oracle.com> <CADzB+2mkR2bQGVpgJ-YqFg4erpmkj7A7eYZec578MRoFSbWhHw@mail.gmail.com> <2fd5f0dd-9ffb-717d-47da-0c114e38fffb@oracle.com> <1530148400.23999.179.camel@redhat.com> <1530148922.23999.181.camel@redhat.com> <2c921336-e188-63c6-bc23-27940745e555@oracle.com> <CADzB+2npGUCE=PPs+ugQWP+0rcjP6CoZm69x33xKejGYANDy7w@mail.gmail.com>

Hi,

On 03/07/2018 18:36, Jason Merrill wrote:

    if ((type_quals & TYPE_QUAL_VOLATILE)
-      && (loc == UNKNOWN_LOCATION || locations[ds_volatile] < loc))
+      && (loc == UNKNOWN_LOCATION
+          || linemap_location_before_p (line_table,
+                                        locations[ds_volatile], loc)))
      loc = locations[ds_volatile];
    if ((type_quals & TYPE_QUAL_RESTRICT)
-      && (loc == UNKNOWN_LOCATION || locations[ds_restrict] < loc))
+      && (loc == UNKNOWN_LOCATION
+          || linemap_location_before_p (line_table,
+                                        locations[ds_restrict], loc)))
      loc = locations[ds_restrict];

Why not use min_location here?

Indeed. Thus I successfully tested the below.

Thanks,
Paolo.

//////////////////////

Attachment: patch_locs_10f
Description: Text document

Follow-Ups:
- Re: [C++ Patch] More location fixes to grokdeclarator
  - From: Jason Merrill

References:
- Re: [C++ Patch] More location fixes to grokdeclarator
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]