This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite/guality, committed] Prevent optimization of local in vla-1.c


On 07/01/2018 09:11 PM, Jakub Jelinek wrote:
> On Sun, Jul 01, 2018 at 06:19:20PM +0200, Tom de Vries wrote:
>> So, the local vla a is optimized away.
>>
>> This patch adds VOLATILE to 'a', which prevents it from being optimized away,
>> and fixes the non-lto failures.
>>
>> Committed as obvious.
> 
> That isn't obvious, it is just wrong.
> The intent of the testcase is to test how debugging of optimized code with
> VLAs works.  With your change we don't test that anymore.  Please revert.
> 

Hi,

Sure, but ... if this is wrong, then for my understanding can you
explain to me how the fail should be addressed?

[ FWIW, I considered this obvious, given the ok for "[testsuite] Fix
guality/pr45882.c for flto"  (
https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01304.html ) which seemed
similar to me. ]

Thanks,
- Tom

>> [testsuite/guality] Prevent optimization of local in vla-1.c
>>
>> 2018-07-01  Tom de Vries  <tdevries@suse.de>
>>
>> 	* gcc.dg/guality/prevent-optimization.h (VOLATILE): Define.
>> 	* gcc.dg/guality/vla-1.c (f1): Mark local vla a as VOLATILE.
> 
> 	Jakub
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]