This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] add support for --disable-gcov
On 2018-06-27 21:22, Rainer Orth wrote:
> Hi Jeff,
>
>>> So add an option for disabling build and install of libgcov and the
>>> related host tools.
>>>
>>> 2018-06-10 Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>>>
>>> gcc/
>>> * configure.ac: Add --disable-gcov option.
>>> * configure: Regenerate.
>>> * Makefile.in: Honour @enable_gcov@.
>>> * doc/install.texi: Document --disable-gcov.
>>>
>>> libgcc/
>>> * configure.ac: Add --disable-gcov option.
>>> * configure: Regenerate.
>>> * Makefile.in: Honour @enable_gcov@.
>> OK. Presumably you're going through the process to get write access.
>> Once that's wrapped up you can install this patch.
>
> this patch badly broke all -fprofile-generate/-fprofile-use tests in the
> default case like this:
>
> UNRESOLVED: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fbranch-probabilities
> FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -O0 -fprofile-arcs
>
> ld: fatal: library -lgcov: not found
> collect2: error: ld returned 1 exit status
> compiler exited with status 1
> FAIL: g++.dg/bprob/g++-bprob-1.C compilation, -g -fprofile-arcs
>
> libgcov.a is not copied over from libgcc to gcc due to a typo in
> libgcc/Makefile.in. Fixed as follows; will install as obvious once
> bootstrap has finished.
>
I'm terribly sorry about that! I was sure I had tested all of
--enable-gcov, --disable-gcov and none of those, and convinced myself
that the default behaviour was unchanged. Thanks for spotting the
problem and fixing it. I will try to be much more careful in the future.
Rasmus