This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PRs fortran/82972, fortran/83088, fortran/85851] Fix ICE with -finit-derived when using iso_c_binding


On Fri, Jun 22, 2018 at 04:46:19PM -0400, Fritz Reese wrote:
> 
> With the patch, the trunk compiler does not exhibit the bugs in the
> mentioned PRs (82972, 83088, 85851). I did encounter some issues
> building and regression testing the trunk compiler which I am certain
> are unrelated. The current trunk fails to bootstrap for me so I am
> using an older revision which appears to have some testcase issues.
> The issues are attached at the bottom of this e-mail for reference.

I applied your patch to my tree and everything passed regression testing.  

> In any case, the changelog is here, and the patch is attached. Aside
> from the issues mentioned below the compile bootstraps and regression
> tests successfully. Does this look OK for trunk? Furthermore, this
> patch comes a bit late as the PRs were submitted before 8.1 was
> released; is it appropriate to backport this to 7-branch and/or
> 8-branch?

I'll read through the patch in more detail tomorrow
(as long as it doesn't interfere with my World Cup
viewing).  As far as backporting, I've always deferred
to the person doing the work.  If you have time and
desire to backport, I don't have an issue with it.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]