This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RISC-V: Add custom RTEMS multilibs
- From: Jim Wilson <jimw at sifive dot com>
- To: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Palmer Dabbelt <palmer at sifive dot com>
- Date: Thu, 14 Jun 2018 11:23:16 -0700
- Subject: Re: [PATCH] RISC-V: Add custom RTEMS multilibs
- References: <20180614045721.7627-1-sebastian.huber@embedded-brains.de>
On Wed, Jun 13, 2018 at 9:57 PM, Sebastian Huber
<sebastian.huber@embedded-brains.de> wrote:
> gcc/
> * config.gcc (riscv*-*-elf* | riscv*-*-rtems*): Use custom
> multilibs for *-*-rtems*.
> * config/riscv/t-rtems: New file.
Looks OK to me. Though I think you can probably self approve patches
like this that only affect the riscv*-*-rtems* port.
I notice that you don't have a MULTILIB_REUSE definition as in
t-elf-multilib. This means you are missing rv32gc and rv64gc
support, which might be a problem as these are common configure and
command line choices. The t-elf-multilib file also uses these for a
few other combinations like rv32ic, rv32imc and ilp32f/rv32gc to
reduce the number of libraries built.
Jim