This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid excessive function type casts with splay-trees part 2
- From: Richard Biener <rguenther at suse dot de>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, David Malcolm <dmalcolm at redhat dot com>
- Date: Thu, 14 Jun 2018 15:43:41 +0200 (CEST)
- Subject: Re: [PATCH] Avoid excessive function type casts with splay-trees part 2
- References: <AM5PR0701MB265733F0AB2E8A999896F93BE47B0@AM5PR0701MB2657.eurprd07.prod.outlook.com>
On Fri, 8 Jun 2018, Bernd Edlinger wrote:
> Hi!
>
>
> This patch converts the splay-tree internals into a template, and makes
> the typed_splay_tree template really type-safe. Previously everything
> would break apart if KEY_TYPE or VALUE_TYPE would not be pointer types.
> This limitation is now removed.
>
> I took the freedom to add a remove function which is only for
> completeness and test coverage, but not (yet) used in a productive way.
>
>
> Bootstrapped and reg-tested on x86_64-linux-gnu.
> Is it OK for trunk?
It looks OK to me but I wonder if we can avoid some of the code
duplication due to template instantiation by deriving from a non-templated
base class somehow? The cc1* binaries keep growing with more and
more template use :/
Thanks,
Richard.