This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC PATCH 1/6] vxworks: add target/h/wrn/coreip to the set of system include paths
Hi Rasmus,
> On 13 Jun 2018, at 08:46, Rasmus Villemoes <rasmus.villemoes@prevas.dk> wrote:
>
>> This include path part alone looks sensible. I'd still like to
>> evaluate how it fares in a environment where many of there variations
>> are exercised, and I'm not quite done with this yet.
>
> Thanks, I do hope for careful scrutiny.
:-)
> As I said, I'm only working on a
> VxWorks 5.5 powerpc target, and I obviously don't want to break stuff
> for other settings, but I can't really test on other combinations than
> the one I have.
> I try to break up the changes in small pieces, maybe
> even smaller than one would usually do, to hopefully get the
> uncontroversial parts upstream, and then we may just have to maintain
> some patches in-house if there's no reasonable way to make it work for
> everybody.
I noticed the effort and appreciate it, thanks.
This particular patch is fine. While I can commit it, I think
it would be nice to let you do it, assuming you will rapidly get
Write After Approval privileges (Thanks Jeff for the sponsoring !).
Still need to think about the other ones and experiment.
I don't think the crti trick will do, and I need to check
what happens for RTPs or SKMs with the rest, see how that
would/should[-not] interact with the mechanisms we have for
Ada, ...