This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Avoid excessive function type casts with splay-trees part 2
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Biener <rguenther at suse dot de>, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 08 Jun 2018 10:28:00 -0400
- Subject: Re: [PATCH] Avoid excessive function type casts with splay-trees part 2
- References: <AM5PR0701MB265733F0AB2E8A999896F93BE47B0@AM5PR0701MB2657.eurprd07.prod.outlook.com>
On Fri, 2018-06-08 at 14:03 +0000, Bernd Edlinger wrote:
> Hi!
>
>
> This patch converts the splay-tree internals into a template, and
> makes
> the typed_splay_tree template really type-safe. Previously
> everything
> would break apart if KEY_TYPE or VALUE_TYPE would not be pointer
> types.
> This limitation is now removed.
>
> I took the freedom to add a remove function which is only for
> completeness and test coverage, but not (yet) used in a productive
> way.
>
>
> Bootstrapped and reg-tested on x86_64-linux-gnu.
> Is it OK for trunk?
Was this testing done with "jit" enabled? (there's some usage of
typed_splay_tree there, for jit's equivalent of switch statements)
Note that the jit frontend isn't covered by "all" in --enable-
languages; it has to be added manually, iirc since it requires --
enable-host-shared.
Thanks
Dave