This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR libstdc++/78870 support std::filesystem on Windows
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 5 Jun 2018 08:36:24 +0100
- Subject: Re: [PATCH] PR libstdc++/78870 support std::filesystem on Windows
- References: <20180531191942.GA12356@redhat.com>
On 31/05/18 20:19 +0100, Jonathan Wakely wrote:
This adds incomplete but functional support for std::filesystem and
std::experimental::filesystem on MinGW. In theory there should be no
changes to the existing behaviour for POSIX targets from this patch,
as all the various bugs I found while working on this have already
been fixed in separate patches.
Tested powerpc64le-linux, and x86_64-w64-mingw32 (with a few expected
FAILures on mingw-w64). Committed to trunk.
This marks some tests as XFAIL for *-*-mingw* because symlinks are not
supported.
Committed to trunk.
commit 3ec85179adb7ab12cb351d25a80147efc4ea174b
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jun 5 08:20:21 2018 +0100
Mark some Filesystem tests as XFAIL for mingw
Symlinks are not supported on mingw.
* testsuite/27_io/filesystem/operations/read_symlink.cc: XFAIL for
mingw* targets.
* testsuite/27_io/filesystem/operations/symlink_status.cc: Likewise.
* testsuite/experimental/filesystem/operations/read_symlink.cc:
Likewise.
diff --git a/libstdc++-v3/testsuite/27_io/filesystem/operations/read_symlink.cc b/libstdc++-v3/testsuite/27_io/filesystem/operations/read_symlink.cc
index c1ef0a3d806..811617b002d 100644
--- a/libstdc++-v3/testsuite/27_io/filesystem/operations/read_symlink.cc
+++ b/libstdc++-v3/testsuite/27_io/filesystem/operations/read_symlink.cc
@@ -18,6 +18,7 @@
// { dg-options "-std=gnu++17 -lstdc++fs" }
// { dg-do run { target c++17 } }
// { dg-require-filesystem-ts "" }
+// { dg-xfail-if "symlinks not supported" { *-*-mingw* } }
#include <filesystem>
#include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/27_io/filesystem/operations/symlink_status.cc b/libstdc++-v3/testsuite/27_io/filesystem/operations/symlink_status.cc
index 45697133f64..919f826b957 100644
--- a/libstdc++-v3/testsuite/27_io/filesystem/operations/symlink_status.cc
+++ b/libstdc++-v3/testsuite/27_io/filesystem/operations/symlink_status.cc
@@ -18,6 +18,7 @@
// { dg-options "-std=gnu++17 -lstdc++fs" }
// { dg-do run { target c++17 } }
// { dg-require-filesystem-ts "" }
+// { dg-xfail-if "symlinks not supported" { *-*-mingw* } }
#include <filesystem>
#include <testsuite_hooks.h>
diff --git a/libstdc++-v3/testsuite/experimental/filesystem/operations/read_symlink.cc b/libstdc++-v3/testsuite/experimental/filesystem/operations/read_symlink.cc
index 9d30593acb8..544e30cbcaa 100644
--- a/libstdc++-v3/testsuite/experimental/filesystem/operations/read_symlink.cc
+++ b/libstdc++-v3/testsuite/experimental/filesystem/operations/read_symlink.cc
@@ -18,6 +18,7 @@
// { dg-options "-DUSE_FILESYSTEM_TS -lstdc++fs" }
// { dg-do run { target c++11 } }
// { dg-require-filesystem-ts "" }
+// { dg-xfail-if "symlinks not supported" { *-*-mingw* } }
#include <experimental/filesystem>
#include <testsuite_hooks.h>