This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX
- From: Jakub Jelinek <jakub at redhat dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 Apr 2018 12:16:03 +0200
- Subject: Re: GCC 8.1 RC1 Bootstrap comparison failure on AIX
- References: <CAGWvnynjNSjL3ubUaPinK0aduBCtunR9+PK3Ad5XWyEi=c-2sg@mail.gmail.com> <CAFiYyc2Ag6586eH+Pdq2eXjqx=cxEkCcviG1+cTM4TaAfrb6hw@mail.gmail.com> <20180426082852.GM8577@tucnak>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Apr 26, 2018 at 10:28:52AM +0200, Jakub Jelinek wrote:
> On Thu, Apr 26, 2018 at 09:56:30AM +0200, Richard Biener wrote:
> > --- gcc/cgraph.h (revision 259668)
> > +++ gcc/cgraph.h (working copy)
> > @@ -2222,7 +2222,7 @@ public:
> > void dump (FILE *f);
> >
> > /* Dump symbol table to stderr. */
> > - inline DEBUG_FUNCTION void debug (void)
> > + DEBUG_FUNCTION void debug (void)
> > {
> > dump (stderr);
> > }
> >
> > fix it?
>
> This is a method defined in the class which is inline even without
> inline keyword, we'd need instead:
Oops, gengtype can't parse it this way, this should work:
2018-04-26 Richard Biener <rguenther@suse.de>
Jakub Jelinek <jakub@redhat.com>
* cgraph.h (symbol_table): Just declare debug method here.
* symtab.c (symbol_table::debug): Define.
--- gcc/cgraph.h.jj 2018-02-09 06:44:29.992809176 +0100
+++ gcc/cgraph.h 2018-04-26 10:22:41.176748872 +0200
@@ -2222,10 +2222,7 @@ public:
void dump (FILE *f);
/* Dump symbol table to stderr. */
- inline DEBUG_FUNCTION void debug (void)
- {
- dump (stderr);
- }
+ void DEBUG_FUNCTION debug (void);
/* Return true if assembler names NAME1 and NAME2 leads to the same symbol
name. */
--- gcc/symtab.c.jj 2018-02-09 06:44:38.389804442 +0100
+++ gcc/symtab.c 2018-04-26 10:25:28.565831384 +0200
@@ -947,6 +947,12 @@ symbol_table::dump (FILE *f)
node->dump (f);
}
+DEBUG_FUNCTION void
+symbol_table::debug (void)
+{
+ dump (stderr);
+}
+
/* Return the cgraph node that has ASMNAME for its DECL_ASSEMBLER_NAME.
Return NULL if there's no such node. */
Jakub