This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] x86/cet: Properly output labels in property note section
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: "H.J. Lu" <hongjiu dot lu at intel dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Uros Bizjak <ubizjak at gmail dot com>, Igor Tsimbalist <igor dot v dot tsimbalist at intel dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Thu, 19 Apr 2018 20:56:24 +0200
- Subject: Re: [PATCH] x86/cet: Properly output labels in property note section
- References: <20180415110617.GA27586@intel.com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> Replace ASM_OUTPUT_LABEL with fprintf so that internal labels in property
> note section are unchanged -fleading-underscore.
>
> OK for trunk?
>
> H.J.
> ---
> gcc/
>
> PR target/85404
> * config/i386/cet.c (file_end_indicate_exec_stack_and_cet):
> Replace ASM_OUTPUT_LABEL with fprintf.
>
> gcc/testsuite/
>
> PR target/85404
> * gcc.target/i386/pr85404.c: New test.
The testcase FAILs on Solaris/x86 with /bin/as:
FAIL: gcc.target/i386/pr85404.c (test for excess errors)
Excess errors:
Assembler: pr85404.c
"/var/tmp//cc_MI..a.s", line 6 : Illegal mnemonic
Near line: " endbr32"
"/var/tmp//cc_MI..a.s", line 6 : Syntax error
Near line: " endbr32"
"/var/tmp//cc_MI..a.s", line 13 : Illegal mnemonic
Near line: " endbr32"
"/var/tmp//cc_MI..a.s", line 13 : Syntax error
Near line: " endbr32"
There are also FAILs on gcc-testresults for i686-pc-linux-gnu,
x86_64-unknown-linux-gnu, and i586-unknown-freebsd10.4 (probably older
versions of gas).
It either needs a dg-require-effective-target cet or be demoted to a
compile test, depending on intent.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University