This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix address sanitizer for powerpc64.
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Bill Seurer <seurer at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 17 Apr 2018 17:45:04 -0500
- Subject: Re: [PATCH, rs6000] Fix address sanitizer for powerpc64.
- References: <8dcd9de1-dfee-fed3-ce56-0fa02e449855@linux.vnet.ibm.com> <20180417222050.GL8577@tucnak>
Hi!
On Wed, Apr 18, 2018 at 12:20:50AM +0200, Jakub Jelinek wrote:
> On Tue, Apr 17, 2018 at 05:15:06PM -0500, Bill Seurer wrote:
> > This patch fixes problems that asan has on powerpc64 running on some old
> > kernels and also very new kernels.
> >
> > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85394 and
> > https://github.com/google/sanitizers/issues/933 for more information.
> >
> > Bootstrapped and tested on powerpc64le-unknown-linux-gnu and
> > powerpc64be-unknown-linux-gnu with no regressions. Is this ok for trunk?
> >
> >
> > 2018-04-17 Bill Seurer <seurer@linux.vnet.ibm.com>
> >
> > PR sanitizer/85389
> > * asan/asan_allocator.h: Switch to use dynamic base for the allocator
> > region.
>
> I'd write
> * asan/asan_allocator.h (kAllocatorSpace): For __powerpc64__ change
> from 0xa0000000000ULL to ~(uptr)0.
>
> Ok with that change and thanks for all the testing.
Same here: thanks!
Segher