This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, openacc, PR85411] Move GOMP_OPENACC_DIM parsing out of nvptx plugin
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>
- Date: Mon, 16 Apr 2018 11:43:19 +0200
- Subject: Re: [PATCH, openacc, PR85411] Move GOMP_OPENACC_DIM parsing out of nvptx plugin
- References: <694a714b-d250-ad64-e015-567e253ef301@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Apr 16, 2018 at 11:41:35AM +0200, Tom de Vries wrote:
> Hi,
>
> this patch moves the parsing of the GOMP_OPENACC_DIM environment variable
> from the nvptx target plugin to the libgomp library.
>
> The variable is not part of the OpenACC standard, but it is specific for the
> gcc implementation of OpenACC, so it makes sense to share the part handling
> the parsing, rather than having each target plugin duplicate it.
>
> Build on x86_64 with nvptx accelerator and reg-tested libgomp.
>
> OK for stage1?
Ok.
> [openacc] Move GOMP_OPENACC_DIM parsing out of nvptx plugin
>
> 2018-04-15 Tom de Vries <tom@codesourcery.com>
>
> PR libgomp/85411
> * plugin/plugin-nvptx.c (notify_var): Remove no longer used function.
> (nvptx_exec): Move parsing of
> GOMP_OPENACC_DIM ...
> * env.c (parse_gomp_openacc_dim): ... here. New function.
> (initialize_env): Call parse_gomp_openacc_dim.
> (goacc_default_dims): Define.
> * libgomp.h (goacc_default_dims): Declare.
> * oacc-plugin.c (GOMP_PLUGIN_acc_default_dim): New function.
> * oacc-plugin.h (GOMP_PLUGIN_acc_default_dim): Declare.
> * libgomp.map: New version "GOMP_PLUGIN_1.2". Add
> GOMP_PLUGIN_acc_default_dim.
> * testsuite/libgomp.oacc-c-c++-common/loop-default-runtime.c: New test.
> * testsuite/libgomp.oacc-c-c++-common/loop-default.h: New test.
Jakub