This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Paul Clarke <pc at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Apr 2018 17:40:39 -0500
- Subject: Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative
- References: <7583e423-6494-5288-0985-01fddc6f59f6@us.ibm.com>
Hi!
On Fri, Apr 13, 2018 at 03:21:14PM -0500, Paul Clarke wrote:
> - if (__builtin_constant_p(__B))
> - lshift = (__v4su) vec_splat_s32(__B);
> + if (__builtin_constant_p(__B) && __B < 16)
> + lshift = (__v4su) vec_splat_s32(__B);
> else
> - lshift = vec_splats ((unsigned int) __B);
> + lshift = vec_splats ((unsigned int) __B);
You changed the tab chars to spaces here. Please don't. I'll fix it.
Rest looks fine... Let's see if I manage to commit it :-)
Thanks,
Segher