This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Ada: Fix s-oscons.ads generation
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: Arnaud Charlet <charlet at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Thomas Quinot <quinot at adacore dot com>
- Date: Thu, 12 Apr 2018 13:10:10 +0200
- Subject: Re: [PATCH] Ada: Fix s-oscons.ads generation
- References: <20180307093456.1424-1-sebastian.huber@embedded-brains.de> <20180307103326.GA9383@adacore.com> <d9c4aecd-94d4-5ec4-2734-ef16e28c5617@embedded-brains.de> <20180307131546.GA7693@adacore.com>
On 07/03/18 14:15, Arnaud Charlet wrote:
The $(GNATLIBCFLAGS) are already included in $(GNATLIBCFLAGS_FOR_C).
We must call the C compiler with the right machine flags. So, add
$(GNATLIBCFLAGS_FOR_C) to $(OSCONS_EXTRACT). For example, on a
bi-arch
compiler supporting 32-bit and 64-bit instruction sets we pick
otherwise
only one variant due to a missing -m32 or -m64 flag.
gcc/ada
* gcc-interface/Makefile.in (OSCONS_CPP): Remove redundant
$(GNATLIBCFLAGS).
(OSCONS_EXTRACT): Add $(GNATLIBCFLAGS_FOR_C).
OK, thanks.
Thanks for the quick review. I would like to back port this to GCC 7.
Seems fine to me if it doesn't cause troubles on trunk.
I back ported this to GCC 7 today.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.