This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Be more carefull about DECL merging in LTO (PR lto/85248).
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 9 Apr 2018 16:00:14 +0200
- Subject: Re: [PATCH] Be more carefull about DECL merging in LTO (PR lto/85248).
- References: <830597eb-a239-2bff-702e-4c8eff40780c@suse.cz>
On Mon, Apr 9, 2018 at 3:55 PM, Martin Liška <mliska@suse.cz> wrote:
> Hi.
>
> Following patch adds checking of noreturn attribute when we merge DECLs in LTO.
> Note that proper fix is probably https://gcc.gnu.org/bugzilla/attachment.cgi?id=43884&action=diff
> but that would be applicable after MPX is removed. Thus in next stage1.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
+ return false;
+ }
+
}
excessive vertical space.
Otherwise OK.
Thanks,
Richard.
> Ready to be installed?
> Martin
>
> gcc/lto/ChangeLog:
>
> 2018-04-06 Richard Biener <rguenther@suse.de>
> Martin Liska <mliska@suse.cz>
>
> PR lto/85248
> * lto-symtab.c (lto_symtab_merge_p): Handle noreturn attribute.
>
> gcc/testsuite/ChangeLog:
>
> 2018-04-06 Jakub Jelinek <jakub@redhat.com>
>
> PR lto/85248
> * gcc.dg/lto/pr85248_0.c: New test.
> * gcc.dg/lto/pr85248_1.c: New test.
> ---
> gcc/lto/lto-symtab.c | 17 ++++++++++++++
> gcc/testsuite/gcc.dg/lto/pr85248_0.c | 45 ++++++++++++++++++++++++++++++++++++
> gcc/testsuite/gcc.dg/lto/pr85248_1.c | 9 ++++++++
> 3 files changed, 71 insertions(+)
> create mode 100644 gcc/testsuite/gcc.dg/lto/pr85248_0.c
> create mode 100644 gcc/testsuite/gcc.dg/lto/pr85248_1.c
>
>