This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [PR c++/84943] allow folding of array indexing indirect_ref
- From: Jason Merrill <jason at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan at acm dot org>
- Date: Mon, 2 Apr 2018 21:16:37 -0400
- Subject: Re: [PATCH] [PR c++/84943] allow folding of array indexing indirect_ref
- References: <ork1u3k95q.fsf@lxoliva.fsfla.org> <CADzB+2k6sJiQcZ+u5iAAdh=SAPy5ie4rZnjg6vFmakPYORmz4Q@mail.gmail.com> <orwoy2py0o.fsf@lxoliva.fsfla.org> <CADzB+2nnSeH1Oe37kG9iWVMrgBGwgxNDKE0SWP9oFqJYvDXR_Q@mail.gmail.com> <CADzB+2kPvPute770350hRx8qACVyvE7ni+-aFLPuxBWEZShuaw@mail.gmail.com> <CADzB+2koRicaeyWMKYu9wpNbFwGHK9qTz2hrTfRbi75r9OeYkQ@mail.gmail.com> <ora7usiuyp.fsf@lxoliva.fsfla.org> <CADzB+2=HUuzBLdg=txnvGBpCEdcQ5-g=cSOJTpU6Kkp+keEnNA@mail.gmail.com> <ortvsyxxq6.fsf@lxoliva.fsfla.org> <orpo3mwcv3.fsf@lxoliva.fsfla.org> <ora7uq6m2d.fsf@lxoliva.fsfla.org> <CADzB+2=75YwaJHL0YF=F4iPwLjh=t3mG24JMG0pdQF5o3TrFfg@mail.gmail.com> <ord0zkzrs1.fsf@lxoliva.fsfla.org>
On Sat, Mar 31, 2018 at 2:24 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Mar 30, 2018, Jason Merrill <jason@redhat.com> wrote:
>
>> I don't think we need this; if arg is overloaded, we take the
>> type_unknown_p early exit, so the code lower down is always dealing
>> with a single function.
>
> Aah, that's why it seemed to me that we had already resolved overloads
> when we got there.
>
> As a bonus, I added the tf_conv test before another mark_used call I'd
> missed in the previous patch.
What if we check tf_conv in mark_used itself rather than at all the call sites?
Jason