This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] C++: show private field accessor hints with -g and optimization (PR c++/84994)

From: Jason Merrill <jason at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Tue, 20 Mar 2018 21:51:31 -0400
Subject: Re: [PATCH 2/2] C++: show private field accessor hints with -g and optimization (PR c++/84994)
References: <1521589032-55200-1-git-send-email-dmalcolm@redhat.com> <1521589032-55200-2-git-send-email-dmalcolm@redhat.com>

On Tue, Mar 20, 2018 at 7:37 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> PR c++/84894 reports that the fix-it hints suggesting accessor calls for
> private fields doesn't work with -g for -O1 and above.
>
> The issue is that field_accessor_p requires DECL_SAVED_TREE (fn) to be
> a RETURN_EXPR, but the former is a STATEMENT_LIST, created in
> start_preparsed_function here:

Would constexpr_fn_retval be useful here?

Jason

Follow-Ups:
- [PATCH v2] C++: show private field accessor hints with -g and optimization (PR c++/84994)
  - From: David Malcolm

References:
- [PATCH 1/2] C++: show private field accessor hints for const accesses (PR c++/84892)
  - From: David Malcolm
- [PATCH 2/2] C++: show private field accessor hints with -g and optimization (PR c++/84994)
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]