Re: [PATCH] Fix PR84873

["Bin.Cheng" <amker dot cheng at gmail dot com>]

On Thu, Mar 15, 2018 at 1:07 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Mar 15, 2018 at 01:56:16PM +0100, Richard Biener wrote:
>> The following fixes the C familiy gimplification langhook to not
>> introduce tree sharing which isn't valid during gimplification.
>> For the specific case the tree sharing is introduced by
>> fold_binary_op_with_cond and is reached via convert () eventually
>> folding something.  I've kept folding constants here but for the
>> rest defer folding to GIMPLE (the gimplifier already folds most
>> generated stmts).
>>
>> Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for trunk and
>> branches?
Hi,
FYI, this causes below failure.

Failures:
        gcc.target/aarch64/var_shift_mask_1.c

Bisected to:


commit 676d61f64d05af5833ddd471cc99229cedbd59b4
Author: rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Mar 15 13:10:24 2018 +0000

    2018-03-15  Richard Biener  <rguenther@suse.de>

         PR c/84873
         * c-gimplify.c (c_gimplify_expr): Do not fold expressions.

         * c-c++-common/pr84873.c: New testcase.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@258556
138bc75d-0d04-0410-961f-82ee72b054a4

I will get more information about the failure.

Thanks,
bin
>>
>> Thanks,
>> Richard.
>>
>> 2018-03-15  Richard Biener  <rguenther@suse.de>
>>
>>       PR c/84873
>>       * c-gimplify.c (c_gimplify_expr): Do not fold expressions.
>>
>>       * c-c++-common/pr84873.c: New testcase.
>
> Ok, thanks.
>
>         Jakub