This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Fix PR 84697
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 6 Mar 2018 14:00:15 -0800
- Subject: Re: [patch, fortran] Fix PR 84697
- Authentication-results: sourceware.org; auth=none
- References: <b5995f78-a509-0db3-17cb-df5b6d21849e@netcologne.de>
- Reply-to: sgk at troutmask dot apl dot washington dot edu
On Tue, Mar 06, 2018 at 10:40:14PM +0100, Thomas Koenig wrote:
>
> the attached patch fixes a bug, partly an 8 regression, for
> simplifying an expression containing minloc or maxloc.
>
> The underlying problem was that
>
> integer, dimension(0), parameter :: z=0
>
> ended up as EXPR_CONSTANT even though the rank was one, which
> was then passed to the simplification routines, which either
> ICEd or gave wrong results.
>
> In doing this, I had to change the logic of the is_size_zero_array
> function. Trying to call it from within the simplification rountines
> led to the simplification routines to be called, and so on... until
> the stack ran out.
>
> As soon as this is committed, I'll also look if there is anything left
> in PR66128, and close that bug if appropriate
I don't think there is anything of value left unless you want to
investigate the old g77 compatibility functions.
>
> Regression-tested. OK for trunk?
>
OK.
--
steve