This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] GCC 7 backport to remove non-ABI vec_vinsert4b and vec_vextract4b support
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Thu, 1 Mar 2018 16:18:19 -0600
- Subject: Re: [PATCH, rs6000] GCC 7 backport to remove non-ABI vec_vinsert4b and vec_vextract4b support
- Authentication-results: sourceware.org; auth=none
- References: <1519931241.5702.26.camel@us.ibm.com>
Hi Carl,
On Thu, Mar 01, 2018 at 11:07:21AM -0800, Carl Love wrote:
> The following patch is a partial backport of mainline commit 257748 to
> remove the vec_vextract4b and vec_vinsert4b support. Note in GCC 7,
> vec_vextract4b is still used so only the external definitions,
> documentation and testcases are removed for vec_vextract4b. All of the
> vec_vinsert4b support is removed.
> This patch has been tested on GCC 7:
>
> powerpc64le-unknown-linux-gnu (Power 8 LE)
> powerpc64-unknown-linux-gnu (Power 8 BE)
>
> with no regressions.
It's a p9 patch, in the future please test such on a p9 as well (or at
least with -mcpu=power9).
> * config/rs6000/altivec.h: Remove vec_vextract4b and vec_vinsert4b.
Mention those removed things on the left:
* config/rs6000/altivec.h (vec_vextract4b, vec_vinsert4b): Delete.
> * config/rs6000/vsx.md: Remove define_expand vinsert4b, define_insn *vinsert4b_internal,
Only one space after :, and this line is too long.
Patch looks fine, thanks! Okay for 7.
Segher