Index: gcc/c/c-typeck.c =================================================================== --- gcc/c/c-typeck.c (revision 257975) +++ gcc/c/c-typeck.c (working copy) @@ -9208,12 +9208,14 @@ output_init_element (location_t loc, tree value, t "enum conversion in initialization is invalid in C++"); } - /* If this field is empty (and not at the end of structure), - don't do anything other than checking the initializer. */ + /* If this field is empty and does not have side effects (and is not at + the end of structure), don't do anything other than checking the + initializer. */ if (field && (TREE_TYPE (field) == error_mark_node || (COMPLETE_TYPE_P (TREE_TYPE (field)) && integer_zerop (TYPE_SIZE (TREE_TYPE (field))) + && !TREE_SIDE_EFFECTS (new_value) && (TREE_CODE (constructor_type) == ARRAY_TYPE || DECL_CHAIN (field))))) return; Index: gcc/testsuite/gcc.dg/pr46921.c =================================================================== --- gcc/testsuite/gcc.dg/pr46921.c (revision 0) +++ gcc/testsuite/gcc.dg/pr46921.c (working copy) @@ -0,0 +1,40 @@ +/* PR c/46921 lost side effect when struct initializer expr uses comma + operator */ + +/* { dg-do run } */ +/* { dg-options "" } */ + +extern int printf(const char *, ...); +extern void abort (void); + +typedef struct __uws_0 { } uw_unit; +uw_unit uw_unit_v = {}; + +struct __uws_1 +{ + struct __uws_0 __uwf_1; + struct __uws_1* __uwf_2; +}; + +static int left_hand_eval = 0; + +static void +foo (const char *s) +{ + ++left_hand_eval; + printf("%s", s); +} + +int +main () +{ + struct __uws_1 tmp = {(foo("Inner\n"), uw_unit_v)}; + + printf("Outer\n"); + /* left hand expression in comma operator initializer must always be + evaluated if there are side effects. */ + if (!left_hand_eval) + abort (); + + return 0; +}