This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] (v2) Update altivec-7 testcase(s).


Hi Will,

On Tue, Feb 27, 2018 at 09:23:12AM -0600, Will Schmidt wrote:
> Move the vsx related content from the altivec-7-be test into
> a new vsx-7-be test.  Split out the VSX specific bits into a vsx-7.h
> header file, and include that when appropriate.

> 	* gcc.target/powerpc/altivec-7-be.c:  Remove VSX content, allow
> 	-32 bit target.

Only one space after ":".  "32-bit target".

> +/* { dg-final { scan-assembler-times {\mlxvd2x\M} 0 { target { p9vector_hw } } } } */
> +/* { dg-final { scan-assembler-times {\mlxvd2x\M} 36 { target { { ! powerpc_p9vector_ok }  &&   powerpc*le-*-* } } } } */
> +/* { dg-final { scan-assembler-times {\mlxvd2x\M} 6 { target { ! powerpc*le-*-* } } } } */

These three conditions are overlapping, and don't cover everything?

The first and the third are both enabled when running on a BE p9 system
(not that those exist, but still).

None are active if compiling for LE p9 on another LE system.

Should the first line have  {powerpc*le-*-* && p9vector_ok}  instead?


Okay for trunk with that sorted out.  Thanks!


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]