This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH/testsuite] avoid test failures with -fpic
- From: Jeff Law <law at redhat dot com>
- To: Martin Sebor <msebor at gmail dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 27 Feb 2018 18:37:31 -0700
- Subject: Re: [PATCH/testsuite] avoid test failures with -fpic
- Authentication-results: sourceware.org; auth=none
- References: <5852525a-f505-6b43-ff7e-d8aa5d34f352@gmail.com>
On 02/26/2018 04:47 PM, Martin Sebor wrote:
> Compiling a number of tests with -fpic results in failures
> because the tests make use of non-inline, extern helper
> functions defined within, and these helpers must be assumed
> to have been superimposed elsewhere.
>
> For example:
> https://gcc.gnu.org/ml/gcc-testresults/2018-02/msg01762.html
>
> I took a quick pass through the failures and declared
> the helpers static to avoid them. I only did this in failure
> tests I recognized because I introduced them myself being unaware
> that building the tests with -fpic was expected to work.
>
> This should make the -fpic test results a lot cleaner than
> they currently are, although I don't think it brings them
> up to par with non-fpic results.
>
> Unless there are objections in the next day or so I'll commit
> the fixes as obvious.
OK.
jeff