This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] -Wformat: fix nonsensical "wide character" message (PR c/84258)

From: David Malcolm <dmalcolm at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Joseph Myers <joseph at codesourcery dot com>
Date: Thu, 08 Feb 2018 14:09:55 -0500
Subject: Re: [PATCH] -Wformat: fix nonsensical "wide character" message (PR c/84258)
Authentication-results: sourceware.org; auth=none
References: <1518054839-58011-1-git-send-email-dmalcolm@redhat.com> <alpine.DEB.2.20.1802081717320.2668@digraph.polyomino.org.uk>

On Thu, 2018-02-08 at 17:18 +0000, Joseph Myers wrote:
> On Wed, 7 Feb 2018, David Malcolm wrote:
> 
> > gcc/c-family/ChangeLog:
> > 	PR c/84258
> > 	* c-format.c (struct format_check_results): Add field
> > 	"number_non_char".
> > 	(check_format_info): Initialize it, and warn if encountered.
> > 	(check_format_arg): Distinguish between wide char and
> > 	everything else when detecting arrays of non-char.
> > 
> > gcc/testsuite/ChangeLog:
> > 	PR c/84258
> > 	* c-c++-common/Wformat-pr84258.c: New test.
> 
> OK.

Thanks.

Release managers: this isn't a regression, but seems relatively low-
risk.

Is this OK for trunk now, or should I queue this for next stage 1?

Context:
  https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00380.html

Dave

References:
- [PATCH] -Wformat: fix nonsensical "wide character" message (PR c/84258)
  - From: David Malcolm
- Re: [PATCH] -Wformat: fix nonsensical "wide character" message (PR c/84258)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]