This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix PR56010 and PR83743, -mcpu=native use wrong names
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Thu, 1 Feb 2018 08:50:46 -0600
- Subject: Re: [PATCH, rs6000] Fix PR56010 and PR83743, -mcpu=native use wrong names
- Authentication-results: sourceware.org; auth=none
- References: <9ac8d237-5bfc-07ba-fe8b-2f877626b67b@vnet.ibm.com> <20180125201851.GS21977@gate.crashing.org> <191034a6-7f6e-cfa3-e234-4282f7e0c6e0@vnet.ibm.com> <ff75e105-5a66-056e-8af4-6dbd6594c43a@vnet.ibm.com> <20180129192332.GB21977@gate.crashing.org> <1ed41366-1572-9501-f15d-b516c2151790@vnet.ibm.com> <20180130001500.GI21977@gate.crashing.org> <4aa8ae90-68e1-4852-ef58-a4ea21d1ea3b@vnet.ibm.com> <20180131173939.GS21977@gate.crashing.org> <5eccb6be-663c-823e-4fdb-336cb403ebbc@vnet.ibm.com>
On Wed, Jan 31, 2018 at 12:16:37PM -0600, Peter Bergner wrote:
> On 1/31/18 11:39 AM, Segher Boessenkool wrote:
> > On Mon, Jan 29, 2018 at 08:55:35PM -0600, Peter Bergner wrote:
> >>
> >> Either that, or I could still call candidates_list_and_hint() and just
> >> throw the hint away, since it's meaningless.
> >
> > It's less code, simpler code, so that would be best I think yes.
>
> Ok, here's the updated patch that uses candidates_list_and hint()
> and throws the hint away because we don't want it. I also removed
> the handling of pa6t like you wanted.
>
> Ok for trunk now? Do we also want this on the release branches?
Yes, okay for trunk. Thanks!
I think we also want this for 7 (after a bit of burn in). I wouldn't
bother with 6 though (the problem has existed since 4.7).
Segher
> PR target/56010
> PR target/83743
> * config/rs6000/driver-rs6000.c: #include "diagnostic.h".
> #include "opts.h".
> (rs6000_supported_cpu_names): New static variable.
> (linux_cpu_translation_table): Likewise.
> (elf_platform) <cpu>: Define new static variable and use it.
> Translate kernel AT_PLATFORM name to canonical name if needed.
> Error if platform name is unknown.