This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000][PR debug/83758] v2 rs6000_internal_arg_pointer should only return a register
Hi!
On Tue, Jan 30, 2018 at 10:21:33AM -0600, Aaron Sawdey wrote:
> This fix looks good, passes bootstrap, go tests run.
>
> Segher is currently regtesting on ppc64le power9. OK for trunk if tests
> pass?
>
> 2018-01-30 Aaron Sawdey <acsawdey@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.c (rs6000_internal_arg_pointer ): Only return
> a reg rtx.
Yes please, with the changelog typo fixed as Jakub said.
Thanks! Glad this is over with :-)
I think it needs backports, too? Those are okay as well.
Segher
> Index: gcc/config/rs6000/rs6000.c
> ===================================================================
> --- gcc/config/rs6000/rs6000.c (revision 257188)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -29602,8 +29602,9 @@
> emit_insn_after (pat, get_insns ());
> pop_topmost_sequence ();
> }
> - return plus_constant (Pmode, cfun->machine->split_stack_arg_pointer,
> - FIRST_PARM_OFFSET (current_function_decl));
> + rtx ret = plus_constant (Pmode, cfun->machine->split_stack_arg_pointer,
> + FIRST_PARM_OFFSET (current_function_decl));
> + return copy_to_reg (ret);
> }
> return virtual_incoming_args_rtx;
> }