This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix various x86 avx512{bitalg, vpopcntdq, vbmi2} issues (PR target/83488)
Hello Julia,
On 24 Jan 14:00, Koval, Julia wrote:
> Hi,
> Fixed it. Ok for trunk?
>
> gcc/
> * config/i386/avx512bitalgintrin.h (_mm512_bitshuffle_epi64_mask,
> _mm512_mask_bitshuffle_epi64_mask, _mm256_bitshuffle_epi64_mask,
> _mm256_mask_bitshuffle_epi64_mask, _mm_bitshuffle_epi64_mask,
> _mm_mask_bitshuffle_epi64_mask): Fix type.
> * config/i386/i386-builtin-types.def (UHI_FTYPE_V2DI_V2DI_UHI,
> USI_FTYPE_V4DI_V4DI_USI): Remove.
> * config/i386/i386-builtin.def (__builtin_ia32_vpshufbitqmb512_mask,
> __builtin_ia32_vpshufbitqmb256_mask,
> __builtin_ia32_vpshufbitqmb128_mask): Fix types.
> * config/i386/i386.c (ix86_expand_args_builtin): Remove old types.
> * config/i386/sse.md (VI1_AVX512VLBW): Change types.
>
> gcc/testsuite/
> * gcc.target/i386/avx512bitalg-vpshufbitqmb-1.c: Add -mavx512f -mavx512bw.
> * gcc.target/i386/avx512bitalgvl-vpshufbitqmb-1.c: Add -mavx512bw.
> * gcc.target/i386/i386.exp: Fix types.
Your patch is OK for trunk. I've checked it in.
--
Thanks, K
>
> Thanks,
> Julia
>
> > -----Original Message-----
> > From: Kirill Yukhin [mailto:kirill.yukhin@gmail.com]
> > Sent: Saturday, January 20, 2018 11:49 AM
> > To: Koval, Julia <julia.koval@intel.com>
> > Cc: 'Jakub Jelinek' <jakub@redhat.com>; 'Uros Bizjak' <ubizjak@gmail.com>;
> > 'GCC Patches' <gcc-patches@gcc.gnu.org>
> > Subject: Re: [PATCH] Fix various x86 avx512{bitalg, vpopcntdq, vbmi2} issues (PR
> > target/83488)
> >
> > Hello Julia,
> > On 12 Jan 08:55, Koval, Julia wrote:
> > > Changelog
> > >
> > > gcc/
> > > * config/i386/avx512bitalgintrin.h (_mm512_bitshuffle_epi64_mask,
> > > _mm512_mask_bitshuffle_epi64_mask,
> > _mm256_bitshuffle_epi64_mask,
> > > _mm256_mask_bitshuffle_epi64_mask, _mm_bitshuffle_epi64_mask,
> > > _mm_mask_bitshuffle_epi64_mask): Fix type.
> > > * config/i386/i386-builtin-types.def (UHI_FTYPE_V2DI_V2DI_UHI,
> > > USI_FTYPE_V4DI_V4DI_USI): Remove.
> > > * config/i386/i386-builtin.def (__builtin_ia32_vpshufbitqmb512_mask,
> > > __builtin_ia32_vpshufbitqmb256_mask,
> > > __builtin_ia32_vpshufbitqmb128_mask): Fix types.
> > > * config/i386/i386.c (ix86_expand_args_builtin): Remove old types.
> > > * config/i386/sse.md (VI48_AVX512VLBW): Change types.
> > >
> > > gcc/testsuite/
> > > * gcc.target/i386/avx512bitalg-vpshufbitqmb-1.c: Add -mavx512f -
> > mavx512bw.
> > > * gcc.target/i386/avx512bitalgvl-vpshufbitqmb-1.c: Add -mavx512bw.
> > > * gcc.target/i386/i386.exp: Fix types.
> >
> > (define_mode_iterator VI48_AVX512VLBW
> > - [(V8DI "TARGET_AVX512BW") (V4DI "TARGET_AVX512VL")
> > - (V2DI "TARGET_AVX512VL")])
> > + [(V64QI "TARGET_AVX512BW") (V32QI "TARGET_AVX512VL")
> > + (V16QI "TARGET_AVX512VL")])
> > I'd call this iterator VI1_AVX512VLBW.
> >
> > --
> > Thanks, K
>