This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][arm] Make gcc.target/arm/copysign_softfloat_1.c more robust
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jan 2018 14:09:34 +0100
- Subject: Re: [PATCH][arm] Make gcc.target/arm/copysign_softfloat_1.c more robust
- Authentication-results: sourceware.org; auth=none
- References: <5A65C162.7020205@foss.arm.com>
Hi Kyrill,
On 22 January 2018 at 11:48, Kyrill Tkachov
<kyrylo.tkachov@foss.arm.com> wrote:
> Hi all,
>
> This test has needlessly restrictive requirements. It tries to force a
> soft-float target and tries to run.
> This makes it unsupportable for any non-soft-float variant.
> In fact, the test can be a run-time test for any target, and only the
> scan-assembler tests are specific to
> -mfloat-abi=soft. So this patch makes the test always runnable and makes the
> scan-assembler checks predicable
> on the the new arm_sotftfloat effective target check.
>
Unfortunately, the test now fails on armeb-linux-gnueabihf (it used to
be unsupported).
my logs only show:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
on arm-linux-gnueabihf, it's OK (the test was unsupported, but now passes)
Christophe
> Committing to trunk.
> Thanks,
> Kyrill
>
> 2018-01-22 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * doc/sourcebuild.texi (arm_softfloat): Document.
>
> 2018-01-22 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * lib/target-supports.exp (check_effective_target_arm_softfloat):
> New procedure.
> * gcc.target/arm/copysign_softfloat_1.c: Allow running everywhere.
> Adjust scan-assembler checks for soft-float.