This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Requested cleanups for BE handling of -mno-speculate-indirect-jumps
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Sat, 20 Jan 2018 11:32:29 -0600
- Subject: Re: [PATCH, rs6000] Requested cleanups for BE handling of -mno-speculate-indirect-jumps
- Authentication-results: sourceware.org; auth=none
- References: <425ae17f-4bca-0bdb-7728-b99ac6dd1b2c@linux.vnet.ibm.com>
Hi!
On Fri, Jan 19, 2018 at 09:46:27PM -0600, Bill Schmidt wrote:
> Segher had previously requested some cleanups in https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01605.html.
> Due to time pressures, I delayed those, but they are ready now. Here they are,
> bootstrapped and tested on powerpc64le-linux-gnu and powerpc64-linux-gnu. Is
> this okay for trunk? I don't intend to backport these.
This is fine for trunk, with one fix (see below). You may want to hold
off on it until the 7 backports are done, but that's up to you.
> 2018-01-19 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * config/rs6000/rs6000.md (*call_indirect_nonlocal_sysv<mode>):
> Simplify the clause that sets the length attribute.
> (*call_value_indirect_nonlocal_sysv<mode>): Likewise.
> (*sibcall_nonlocal_sysv<mode>): Clean up code block; simplify the
> clause that sets the length attribute.
> (*sibcall_value_nonlocal_sysv<mode>): Likewise.
> /* Can use CR0 since it is volatile across sibcalls. */
> - return \"crset eq\;beq%T0-\;b $\";
> + return "crset eq;beq%T0-;b $";
This should still use \; .
> /* Can use CR0 since it is volatile across sibcalls. */
> - return \"crset eq\;beq%T1-\;b $\";
> + return "crset eq;beq%T1-;b $";
Same here.
Thanks for the patch,
Segher