This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH for c++/83714, ICE checking return from template


On Wed, Jan 17, 2018 at 4:31 PM, Jason Merrill <jason@redhat.com> wrote:
> On Wed, Jan 17, 2018 at 3:46 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
>> Hi Jason,
>>
>> On 17/01/2018 00:04, Jason Merrill wrote:
>>>
>>> Like my recent patch for 83186, we were missing a
>>> build_non_dependent_expr.
>>>
>>> Tested x86_64-pc-linux-gnu, applying to trunk.
>>
>> Lately I'm seeing (H.J. Lu too) a regression:
>>
>> FAIL: g++.dg/template/inherit4.C -std=c++11 (test for excess errors)
>> FAIL: g++.dg/template/inherit4.C -std=c++14 (test for excess errors)
>>
>> which seems related to this change of yours: if I comment out the new
>> build_non_dependent_expr call the test is accepted again. Could you please
>> have a look?
>
> Hmm, wonder why I didn't see that in my testing.  Checking a fix now.

We were failing to treat A::foo_ as an instantiation-dependent
SCOPE_REF, which it is because of the dependent base B<T>.

Tested x86_64-pc-linux-gnu, applying to trunk.

Attachment: inh4.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]