Re: [PATCH][arm] Fix gcc.target/arm/pr40887.c directives

[Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>]

On 18/01/18 09:15, Christophe Lyon wrote:
> Hi Kyrill,
>
>
> On 17 January 2018 at 12:20, Kyrill  Tkachov
> <kyrylo.tkachov@foss.arm.com> wrote:
> > Hi all,
> >
> > This patch converts gcc.target/arm/pr40887.c to use the proper effective
> > target check and dg-add-options for armv5te
> > so that we avoid situations where we end up trying to compile the test with
> > a Thumb1 hard-float ABI, which makes the
> > compiler complain.
> >
> > This allows the test to pass gracefully for me for my compiler configured
> > with:
> > --with-cpu=cortex-a15 --with-fpu=neon-vfpv4 --with-float=hard
> > --with-mode=thumb
> >
> > Committing to trunk.
> >
> > Thanks,
> > Kyrill
> >
> > 2018-01-17  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> >
> >      * gcc.target/arm/pr40887.c: Add armv5te effective target checks and
> >      directives.
> I think you had to swap dg-options and dg-add-options directives, so I
> committed the attached patch as obvious.

Thanks Christophe,
I had spotted it and was planning to fix it by using dg-additional-options,
but it's the same in the end.

Kyrill

> Christophe