This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)
- From: Richard Biener <rguenther at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: John David Anglin <dave dot anglin at bell dot net>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Jan 2018 09:18:21 +0100 (CET)
- Subject: Re: [PATCH] Add clobbers for callee copied argument temporaries (PR sanitizer/81715, PR testsuite/83882)
- Authentication-results: sourceware.org; auth=none
- References: <20180117200749.GX2063@tucnak> <alpine.LSU.2.20.1801180908450.32271@zhemvz.fhfr.qr> <20180118081455.GB2063@tucnak>
On Thu, 18 Jan 2018, Jakub Jelinek wrote:
> On Thu, Jan 18, 2018 at 09:10:03AM +0100, Richard Biener wrote:
> > On Wed, 17 Jan 2018, Jakub Jelinek wrote:
> >
> > > Hi!
> > >
> > > PR83882 complains that PR81715 testcase fails on callee copies parameter
> > > targets. The following patch ought to fix that, but I have only
> > > bootstrapped/regtested it on x86_64-linux and i686-linux + on the testcase
> > > with hppa.
> >
> > Looks reasonable.
> >
> > > John, do you think you could test this on hppa without the callee copies
> > > default change?
> > >
> > > Or should we not care anymore if there aren't any similar targets left?
> >
> > How's that communicated to the middle-end anyways?
>
> You mean the callee copies stuff? gimplify_parameters creates new
> temporaries, assigns the parameter to them, set DECL_VALUE_EXPR on the
> parameters to the temporary and at the end of function clears
> DECL_VALUE_EXPR and with this patch adds a CLOBBER in a cleanup as well.
No, I meant whether the target wants this or not.
Richard.