This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Move pa.h FUNCTION_ARG_SIZE to pa.c (PR83858)
- From: John David Anglin <dave dot anglin at bell dot net>
- To: gcc-patches at gcc dot gnu dot org, law at redhat dot com, richard dot sandiford at linaro dot org
- Date: Tue, 16 Jan 2018 09:42:34 -0500
- Subject: Re: Move pa.h FUNCTION_ARG_SIZE to pa.c (PR83858)
- Authentication-results: sourceware.org; auth=none
- References: <87lggyxehb.fsf@linaro.org>
On 2018-01-16 5:52 AM, Richard Sandiford wrote:
2018-01-16 Richard Sandiford<richard.sandiford@linaro.org>
gcc/
PR target/83858
* config/pa/pa.h (FUNCTION_ARG_SIZE): Delete.
* config/pa/pa-protos.h (pa_function_arg_size): Declare.
* config/pa/som.h (ASM_DECLARE_FUNCTION_NAME): Use
pa_function_arg_size instead of FUNCTION_ARG_SIZE.
* config/pa/pa.c (pa_function_arg_advance): Likewise.
(pa_function_arg, pa_arg_partial_bytes): Likewise.
(pa_function_arg_size): New function.
Thanks Richard. I started a build yesterday evening with essentially
the same change.
Two little nits. I believe a declaration for pa_function_arg_size needs
to be added
be added to added pa-protos.h. Secondly, the comment for
pa_function_arg_size
needs to be updated to say "function" instead of "macro". Otherwise, the
change
is okay.
I want to see if ASM_DECLARE_FUNCTION_NAME can be turned into a function in
pa.c as well. This would allow pa_function_arg_size to be static.
Dave
--
John David Anglin dave.anglin@bell.net