Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

[Richard Biener <richard dot guenther at gmail dot com>]

On Mon, Jan 15, 2018 at 5:53 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Jan 15, 2018 at 3:38 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Jan 15, 2018 at 12:31 AM, Richard Biener
>> <richard.guenther@gmail.com> wrote:
>>> On Sun, Jan 14, 2018 at 4:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> Now my patch set has been checked into trunk.  Here is a patch set
>>>> to move struct ix86_frame to machine_function on GCC 7, which is
>>>> needed to backport the patch set to GCC 7:
>>>>
>>>> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01239.html
>>>> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01240.html
>>>> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01241.html
>>>>
>>>> OK for gcc-7-branch?
>>>
>>> Yes, backporting is ok - please watch for possible fallout on trunk and make
>>> sure to adjust the backport accordingly.  I plan to do GCC 7.3 RC1 on
>>> Wednesday now with the final release about a week later if no issue shows
>>> up.
>>>
>>
>> Backport is blocked by
>>
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83838
>>
>> There are many test failures due to lack of comdat support in linker on Solaris.
>> I can limit these tests to Linux.
>
> These are testcase issues and shouldn't block backport to GCC 7.

It makes the option using thunks unusable though, right?  Can you simply make
them hidden on systems without comdat support?  That duplicates them per TU
but at least the feature works.  Or those systems should provide the thunks via
libgcc.

I agree we can followup with a fix for Solaris given lack of a public
testing machine.

Richard.

>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83839
>>
>> Bootstrap failed on Dawning due to lack of ".set" directive in assembler.  I
>> uploaded a patch:
>>
>> https://gcc.gnu.org/bugzilla/attachment.cgi?id=43124
>>
>> There is no confirmation on it.  Also there may be test failures on Dardwin
>> due to difference in assembly output.
>
> I posted a patch for Darwin build:
>
> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01347.html
>
> This needs to be checked into trunk before I can start backport to GCC 7.
>
> --
> H.J.