Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

[Tom de Vries <Tom_deVries at mentor dot com>]

On 01/07/2018 02:17 PM, Tom de Vries wrote:
> On 01/06/2018 12:36 PM, Jakub Jelinek wrote:
> > On Sat, Jan 06, 2018 at 09:21:59AM +0100, Tom de Vries wrote:
> > > this patch adds the following builtins in C/C++:
> > > - __builtin_goacc_gang_id
> > > - __builtin_goacc_worker_id
> > > - __builtin_goacc_vector_id
> > > - __builtin_goacc_gang_size
> > > - __builtin_goacc_worker_size
> > > - __builtin_goacc_vector_size
> >
> > I wonder if it wouldn't be better to have just 2 builtins instead of 6,
> > with one argument (required to be constant) - the kind of parallelism
> > you're interested in, to avoid the inflation of the builtins.
>
> Like so:
> - __built_goacc_id
> - __built_goacc_size
> ?

Hi,

I understand this is more of a stage1 patch and has no priority atm, but 
if the concept as such is acceptable can we at least settle on the name 
and interface?

Thanks,
- Tom