Re: [PATCH] PR 78534, 83704 Large character lengths

[Janne Blomqvist <blomqvist dot janne at gmail dot com>]

On Wed, Jan 10, 2018 at 3:35 PM, Dominique d'Humières
<dominiq@tournesol.lps.ens.fr> wrote:
> Hi Janne,
>
> With this patch, bootstrap fails with
>
> ../../work/gcc/fortran/array.c: In function 'bool gfc_resolve_character_array_constructor(gfc_expr*)':
> ../../work/gcc/fortran/array.c:2062:36: error: unknown conversion type character 'l' in format [-Werror=format=]
>      current_length, &p->expr->where);
>                                     ^
> ../../work/gcc/fortran/array.c:2062:36: error: unknown conversion type character 'l' in format [-Werror=format=]
> ../../work/gcc/fortran/array.c:2062:36: error: format '%L' expects argument of type 'locus*', but argument 2 has type 'long long int' [-Werror=format]
> ../../work/gcc/fortran/array.c:2062:36: error: too many arguments for format [-Werror=format-extra-args]
>
> Note that trying to only update I saw the same problem for data.c:179 and decl.c:1570/1580.

Please try the attached patch on top of the original.

Ok for trunk with that change?

(I don't know why HOST_WIDE_INT_PRINT_DEC doesn't work with the
diagnostics machinery on darwin, but IMHO at this point it's too late
to do surgery there for the GCC-8 release. So I suggest the attached
patch, and then at some future stage1 someone with an interest in
win64 or crosscompiling from a 32-bit host to a 64-bit target can look
into the issue.)



-- 
Janne Blomqvist

Attachment: long.diff
Description: Text document