This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH to add a test for c++/81860


On Fri, Jan 12, 2018 at 10:12:15AM +0100, Rainer Orth wrote:
> Hi Nathan,
> 
> >> On 01/02/2018 09:36 AM, Marek Polacek wrote:
> >>> This test exercising inheriting a template constructor in this PR got
> >>> fixed with
> >>> r251426.  As I don't see any lambdas here, I thought it worth to add it.
> >>>
> >>> Tested on x86_64-linux, ok for trunk?
> >>>
> >>> 2018-01-02  Marek Polacek  <polacek@redhat.com>
> >>>
> >>> 	PR c++/81860
> >>> 	* g++.dg/cpp0x/inh-ctor30.C: New test.
> >>>
> >>
> >> yes thanks
> >
> > this test FAILs on a couple of targets: i386-pc-solaris2.1[01],
> > sparc-sun-solaris2.11, powerpc-ibm-aix7.2.0.0,
> > x86_64-apple-darwin15.6.0.
> >
> > The former two have _ZN1AIjEC1Ev instead of _ZN1AIjEC2Ev which demangle
> > the same.  Should it accept both?

Sorry, I've been meaning to fix this.

> the following patch passed testing on i386-pc-solaris2.1[01] and
> sparc-sun-solaris2.1[01].  Ok for mainline?

This is the change I intended to do.  So I think just commit the patch,
thanks.

> 2018-01-11  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	* g++.dg/cpp0x/inh-ctor30.C: Allow for alternate mangled form.
> 

> # HG changeset patch
> # Parent  ad7853c94ad4b3bb2a66b5332a43d307005b138e
> Fix g++.dg/cpp0x/inh-ctor30.C
> 
> diff --git a/gcc/testsuite/g++.dg/cpp0x/inh-ctor30.C b/gcc/testsuite/g++.dg/cpp0x/inh-ctor30.C
> --- a/gcc/testsuite/g++.dg/cpp0x/inh-ctor30.C
> +++ b/gcc/testsuite/g++.dg/cpp0x/inh-ctor30.C
> @@ -1,6 +1,6 @@
>  // PR c++/81860
>  // { dg-do compile { target c++11 } }
> -// { dg-final { scan-assembler "_ZN1AIjEC2Ev" } }
> +// { dg-final { scan-assembler "_ZN1AIjEC\[12\]Ev" } }
>  
>  template <typename T>
>  struct A


	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]