This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Add vec_mergee, vec_mergeo, vec_float2 builtin support
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 8 Jan 2018 06:33:44 -0600
- Subject: Re: [PATCH, rs6000] Add vec_mergee, vec_mergeo, vec_float2 builtin support
- Authentication-results: sourceware.org; auth=none
- References: <1513642206.29258.51.camel@us.ibm.com>
Hi Carl,
On Mon, Dec 18, 2017 at 04:10:06PM -0800, Carl Love wrote:
> --- a/gcc/config/rs6000/altivec.md
> +++ b/gcc/config/rs6000/altivec.md
> @@ -1,3 +1,4 @@
> +
> ;; AltiVec patterns.
> ;; Copyright (C) 2002-2017 Free Software Foundation, Inc.
> ;; Contributed by Aldy Hernandez (aldy@quesejoda.com)
Please lose this change.
> +;; Power8 vector merge two V2DF/V2DI even words to V2DF
> +(define_expand "p8_vmrgew_<mode>"
> + [(use (match_operand:VSX_D 0 "vsx_register_operand" ""))
> + (use (match_operand:VSX_D 1 "vsx_register_operand" ""))
> + (use (match_operand:VSX_D 2 "vsx_register_operand" ""))]
Drop the empty default field please (here and elsewhere, certainly in all
expanders).
It looks good to me otherwise. Okay for trunk. Thanks!
Segher