This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 78534 Change character length from int to size_t
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: Jerry DeLisle <jvdelisle at charter dot net>, Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Jan 2018 14:22:34 +0200
- Subject: Re: [PATCH] PR 78534 Change character length from int to size_t
- Authentication-results: sourceware.org; auth=none
- References: <1514554310-27231-1-git-send-email-blomqvist.janne@gmail.com> <40a2fbf9-d997-0e88-3754-e5e80629b4d1@netcologne.de> <CAO9iq9G=b1WSELO2M+hQTOjcCdn4QHH4NVX_g0iFT=DAe3yodQ@mail.gmail.com> <6e2a8ac3-41e2-3503-1d9e-6a9dfe6be52f@netcologne.de> <CAO9iq9FeA3nr-ZXgQPk4zz8HOR7iEkQnKwGP=YGYe0gF69p4Bw@mail.gmail.com> <1751d219-7012-1b17-e2f2-b358a60d1d21@charter.net> <CAO9iq9G_jzt+yojtL8BqgbrARL0TH=P5Wd5Lbvu2y+Y4MX14sg@mail.gmail.com> <125747b4-3778-ff1d-23b9-c2f572d85abc@netcologne.de>
On Wed, Jan 3, 2018 at 2:10 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Janne,
>
>> attached is a patch that makes the two attached testcases work. It
>> applies on top of the charlen->size_t patch. In the formatted I/O
>> stuff, I have mostly used ptrdiff_t to avoid having to deal with
>> signed/unsigned issues, as the previous code was using int.
>
>
> Did you regression-test?
Ah yes, I forgot to mention that. Yes, I did, though only on x86_64-linux-gnu
> If yes, I'd say this patch is OK (all the changes look obvious
> enough).
>
> With this, your character length patch is also OK. We can then
> open individual PRs for the other issues.
>
> However, I'd ask you to wait for a day or so with committing
> so that other people also have a chance for a (final) look
> at this.
Thanks! Dominique mentioned on IRC about some incoming comments, so I
guess it makes sense to wait a few days.
--
Janne Blomqvist