This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Fix error recovery ICEs (PR c/83595)
- From: Marek Polacek <polacek at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Sun, 31 Dec 2017 19:07:42 +0100
- Subject: Re: [C PATCH] Fix error recovery ICEs (PR c/83595)
- Authentication-results: sourceware.org; auth=none
- References: <20171230193725.GP1833@tucnak>
On Sat, Dec 30, 2017 at 08:37:25PM +0100, Jakub Jelinek wrote:
> Hi!
>
> As the patch shows, in lots of spots the C FE can return a c_expr
> with error_mark_node value, but uninitialized locations, so if something
> calls expr.get_location (), it can ICE.
>
> Other spots are already using the set_error method which sets the value
> to error_mark_node and in addition to that clears the locations.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
Ok.
Marek