This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add selftest for vec::reverse
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 29 Dec 2017 12:09:02 -0500
- Subject: Re: [PATCH] Add selftest for vec::reverse
- Authentication-results: sourceware.org; auth=none
- References: <82167884-d00e-a87c-9f22-94f5cd6e834d@suse.cz> <1507306833-12644-1-git-send-email-dmalcolm@redhat.com> <fc1dd7e3-d983-eae9-4856-df338dbc48b0@suse.cz>
On Fri, 2017-12-29 at 15:39 +0100, Martin Liška wrote:
> On 10/06/2017 06:20 PM, David Malcolm wrote:
> > Martin: I noticed that your switch expansion patch added a
> > vec::reverse ()
> > method. Here's a proposed selftest for it, mostly to verify
> > that it handles even vs odd lengths (which it does).
> >
> > Only lightly tested; hope this is useful.
> > Dave
>
> Hi.
>
> I like it! Do you want to commit it before there will be
> a consumer of the function?
>
> Martin
Looks like vec::reverse isn't in trunk yet. I don't have a strong
opinion on whether vec::reverse should be added without a "real"
consumer, or added when the consumer is added, but feel free to add my
selftest patch into whichever patch adds vec::reverse.