This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: a new libgcov interface: __gcov_dump_all
- From: Martin Liška <mliska at suse dot cz>
- To: Xinliang David Li <davidxl at google dot com>, Nathan Sidwell <nathan at acm dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 29 Dec 2017 15:17:51 +0100
- Subject: Re: a new libgcov interface: __gcov_dump_all
- Authentication-results: sourceware.org; auth=none
- References: <CAAkRFZLuXyevU9xUmq1AFKEq+JjTH-G=Oe0pWWY=MkkxMR5jHA@mail.gmail.com> <53CC1BBC.1020008@acm.org> <CAAkRFZJfke3=b3YCXd3gnCnQ=2m_ikKLDOtyT8XDyHf4DbMEHg@mail.gmail.com> <53CCAF4F.8030603@acm.org> <CAAkRFZL97Tp3Xfexh+-So43juYUsPar1yQKgHLSXu8jt0PNYnw@mail.gmail.com> <f3f33000-0c81-57b7-3bbd-53f53aed50f9@suse.cz>
On 10/26/2017 10:47 AM, Martin Liška wrote:
> On 07/22/2014 06:04 PM, Xinliang David Li wrote:
>> Please take a look the updated patch. It addresses the issue of using
>> dlclose before dump, and potential races (between a thread closing a
>> library and the dumper call).
>>
>> David
>>
>> On Sun, Jul 20, 2014 at 11:12 PM, Nathan Sidwell <nathan@acm.org> wrote:
>>> On 07/20/14 21:38, Xinliang David Li wrote:
>>>>
>>>> The gcov_info chain is not duplicated -- there is already one chain
>>>> (linking only modules of the library) per shared library in current
>>>> implementation. My change does not affect underlying behavior at all
>>>> -- it merely introduces a new interface to access private dumper
>>>> methods associated with shared libs.
>>>
>>>
>>> ah, got it. thanks for clarifying. Can't help thinking gcov_init should be
>>> doing this, and wondering about dlload/dlclose. Let me think
>>>
>>> nathan
>
> Hi.
>
> Unfortunately, it looks the patch hasn't been installed to trunk. Some folks from Firefox
> are interested in that.
>
> Are you Nathan OK with the patch? I guess a rebase will be needed.
>
> Martin
>
Hi.
I would like to suspend the patch review as there's actually no call for the feature.
The person which sent me the link actually wanted to dump all counters. That can be
easily done via __gcov_dump interface we already have.
Martin