This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, lingfortran] Bug 83560 - list-directed formatting of INTEGER is missing plus on output
- From: Jerry DeLisle <jvdelisle at charter dot net>
- To: Dominique d'Humières <dominiq at tournesol dot lps dot ens dot fr>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 25 Dec 2017 12:06:51 -0800
- Subject: Re: [patch, lingfortran] Bug 83560 - list-directed formatting of INTEGER is missing plus on output
- Authentication-results: sourceware.org; auth=none
- References: <948C8E67-54AF-4696-93A6-4D1155A72C9F@lps.ens.fr>
On 12/25/2017 05:10 AM, Dominique d'Humières wrote:
> Dear Jerry,
>
> The lines
>
> +a=12.3456
>
> and
>
> +open(unit=10,sign='plus')
>
> in gfortran.dg/integer_plus.f90 could probably be removed.
>
Yes, left over from some other testing I was doing
> From comment 2 in the PR (and the attached test), it seems that the reporter is expecting sign=‘plus’ to apply also to namelists, which is not the case with this patch.
>
> This seems supported by (my understanding of)
>
>> 10.11.4.2 Namelist output editing
>>
>> 1 Values in namelist output records are edited as for list-directed output (10.10.4).
>
> Merry Christmas!
>
> Dominique
>
>
What I did last night made perfect sense at the time. Now, your point well
taken. The previous write_integer suppressed leading spaces nicely for writing
repeat counts, write_decimal does not do this directly. I am going to have to be
careful we don't put plus signs on repeat counts.
Merry Christmas to you and all!
Jerry