This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix avx512vnnivlintrin.h builtins (PR target/83488)
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 22 Dec 2017 15:51:49 +0300
- Subject: Re: [PATCH] Fix avx512vnnivlintrin.h builtins (PR target/83488)
- Authentication-results: sourceware.org; auth=none
- References: <D511F25789BA7F4EBA64C8A63891A00291F6AA5A@IRSMSX102.ger.corp.intel.com> <CAFULd4a=VrgeOzsTPvUu8L+c=qO4Y98T5vK=miknQoz=8agM+Q@mail.gmail.com> <20171222110554.GJ2353@tucnak>
Hello Jakub,
On 22 Dec 12:05, Jakub Jelinek wrote:
> On Fri, Dec 22, 2017 at 11:41:27AM +0100, Uros Bizjak wrote:
> > > Ok for trunk?
> >
> > OK.
>
> On top of this patch and the reason why we needed to move avx512vnni
> from flags2 to flags instead of just:
> case OPT_mavx512vnni:
> if (value)
> {
> opts->x_ix86_isa_flags2 |= OPTION_MASK_ISA_AVX512VNNI_SET;
> opts->x_ix86_isa_flags2_explicit |= OPTION_MASK_ISA_AVX512VNNI_SET;
> - opts->x_ix86_isa_flags2 |= OPTION_MASK_ISA_AVX512F_SET;
> - opts->x_ix86_isa_flags2_explicit |= OPTION_MASK_ISA_AVX512F_SET;
> + opts->x_ix86_isa_flags |= OPTION_MASK_ISA_AVX512F_SET;
> + opts->x_ix86_isa_flags_explicit |= OPTION_MASK_ISA_AVX512F_SET;
> }
>
> the following patch does:
> 1) adds a testcase (-2.c) where trunk without your patch ICEs, because
> -mno-avx -mavx512vnni didn't enable -mavx512f when it should
> 2) as that is now enabled, there is no need for the avx512vnniintrin.h
> header to work-around that bug
> 3) adds " | OPTION_MASK_ISA_AVX512VL" to builtins that need both avx512vnni
> and avx512vl
> 4) adds a testcase (-3.c) that ICEs without the 3) change, where we allow
> the builtin, but ICE because the underlying insn isn't available
>
> Will bootstrap/regtest this on x86_64-linux and i686-linux soon, ok for
> trunk if it passes bootstrap/regtest?
Patch is OK if no issues.
--
Thanks, K